updated config loader to accept absolute paths to config files #3118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLHwung
requested changes
Apr 17, 2018
lib/hexo/multi_config_path.js
Outdated
| let configPath = defaultPath; | ||
|
|
||
| // check for absolute config file | ||
| if (pathFn.isAbsolute(configPaths)) { |
There was a problem hiding this comment.
It can be simplified to
configPath = pathFn.isAbsolute(configPaths) ? configPaths ? pathFn.resolve(base, configPaths);
then we can check fs.existsSync in a single branch.
There was a problem hiding this comment.
Nice add. Looks good to me.
There was a problem hiding this comment.
@JLHwung do I need to implement these changes on my branch? Or can you do it as a collaborator directly via GitHub?
|
@JLHwung I implemented your requested changes. Let me know if there is anything else. |
JLHwung
approved these changes
Apr 26, 2018
thom4parisot
pushed a commit
to thom4parisot/hexo
that referenced
this pull request
Jan 17, 2020
…s#3118) * updated config loader to accept absolute paths to config files * fixes for coveralls and codeclimate * refactored isAbsolute() check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to support absolute paths to config files.
Commit checklist: